Make the block settings menu item dynamic #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really reallly dig this 🏅 👍 👍 from me for all of this. Code looks good to me too, though it couldn't hurt to get a quick 👍 from @youknowriad. |
aduth
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the interaction with the "Settings" menu item in the blocks "ellipsis" menu as detailed in #3340 (comment)
TODO: add a
speakmessage when the sidebar block tab opens.It's a first try to test if the new interaction makes sense, can be improved later.
Basically the item label and action are "dynamic" meaning they change based on the sidebar tab state:
Also, renames the label (and tooltip) for the block ellipsis menu: I've opted for "More options", inspired by a similar control in Gmail > compose:
Note: when a control uses
aria-expanded, it's better to not change its label as, for example:Open Settings Menu - collapsedClose Settings Menu - expandedwould sound a bit weird. Note that the similar control in Gmail uses aria-expanded and doesn't change the label.
Also renames the sidebar ARIA region to
Editor advanced settings.Fixes #3340